8000 BUG: Use larger fetch depth in gitpod.yml by charris · Pull Request #19132 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Use larger fetch depth in gitpod.yml #19132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2021

Conversation

charris
Copy link
Member
@charris charris commented May 28, 2021

Change the checkout@v2 fetch-depth parameter to zero, which means
everything. We could probably use a smaller number, but a full
checkout should only add a minute or two.

Related to #19119.

See https://github.com/actions/checkout for an explanation of the checkout@v2 parameters.

Change the checkout@v2 fetch-depth parameter to zero, which means
everything. We could probably use a smaller number, but a full
checkout should only add a minute or two.
@charris
Copy link
Member Author
charris commented May 28, 2021

@trallard Ping.

@charris
Copy link
Member Author
charris commented May 28, 2021

If the full fetch is only needed to build NumPy, we could use a smaller clone after.

@trallard
Copy link
Contributor

It looks good to me and makes sense since we are only doing a quick build

@charris
Copy link
Member Author
charris commented May 29, 2021

Let's give this a try. Shame we have to merge to find out...

@charris charris merged commit 1ad61f0 into numpy:main May 29, 2021
@charris
Copy link
Member Author
charris commented May 29, 2021

That fixed the gitpod problem.

@charris charris deleted the fix-gitpod-fetch-depth branch May 29, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0