10000 MAINT, SIMD: Pass divisor by refernce in npyv_divc_* by ganesh-k13 · Pull Request #19114 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT, SIMD: Pass divisor by refernce in npyv_divc_* #19114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

MAINT, SIMD: Pass divisor by refernce in npyv_divc_* #19114

wants to merge 8 commits into from

Conversation

ganesh-k13
Copy link
Member

Changes:

Make npyv_divc_* functions take a pointer for the divisor.

ref: #19077

cc: @seiko2plus @seberg

@ganesh-k13
Copy link
Member Author

As @mattip mentioned:

Some of those errors/warnings will be difficult to fix since LGTM's ideas may not agree with ours.

This looks like one of those where it might not make sense to do :). Let me know if this change is needed.

@seiko2plus
Copy link
Member

These intrinsics are forced to be inline, struct npyv_{type}x3 only holds vectors registers, this technique has been adopted by ARM/neon API and it looks pretty safe to me. Therefore, I totally agree with Matti's opinion "Some of LGTM's ideas may not agree with ours".

@ganesh-k13
Copy link
Member Author

Thanks for the info @seiko2plus, makes sense yeah. I'll close this for now 👍

@ganesh-k13 ganesh-k13 closed this May 28, 2021
@rgommers rgommers added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews 545E
Assignees
No one assigned
Labels
03 - Maintenance component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganesh-k13 @seiko2plus @rgommers
0