8000 ENH: Improve error message in multinomial by bashtage · Pull Request #18482 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: Improve error message in multinomial #18482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 27, 2021
Merged

ENH: Improve error message in multinomial #18482

merged 4 commits into from
Feb 27, 2021

Conversation

bashtage
Copy link
Contributor

Improve error message when the sum of pvals is larger than 1
when the input data is an ndarray

closes #8317
xref #16732

@bashtage
Copy link
Contributor Author

Supercedes #16732 with the simplest route which is an improved error in the edge case mentioned in the original issue.

@bashtage bashtage closed this Feb 24, 2021
@bashtage bashtage reopened this Feb 24, 2021
eric-wieser
eric-wieser reviewed Feb 24, 2021
View reviewed changes
@bashtage bashtage force-pushed the multinomial-pvals-err branch 2 times, most recently from 6e08556 to 3d43508 Compare February 24, 2021 14:29
eric-wieser
eric-wieser reviewed Feb 24, 2021
View reviewed changes
charris
charris reviewed Feb 26, 2021
View reviewed changes
charris
charris reviewed Feb 26, 2021
View reviewed changes
charris
charris reviewed Feb 26, 2021
View reviewed changes
charris
charris reviewed Feb 26, 2021
View reviewed changes
charris
charris reviewed Feb 26, 2021
8000
View reviewed changes
bashtage and others added 3 commits February 26, 2021 22:41
@bashtage
ENH: Improve error message in multinomial
9e068f4 
Improve error message when the sum of pvals is larger than 1
when the input data is an ndarray

closes numpy#8317
xref numpy#16732
@bashtage @eric-wieser
Accept suggestion
2ee92e2 
Use if else.

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Address comments
e900be2
@bashtage bashtage force-pushed the multinomial-pvals-err branch from 0bd6003 to e900be2 Compare February 26, 2021 23:01
@bashtage bashtage force-pushed the multinomial-pvals-err branch from 14d2bec to b1015ad Compare February 26, 2021 23:45
@charris charris merged commit 9a2a786 into numpy:master Feb 27, 2021
@charris
Copy link
Member
charris commented Feb 27, 2021

Thanks Kevin.

@bashtage bashtage deleted the multinomial-pvals-err branch April 21, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@charris charris charris approved these changes

Assignees
No one assigned
Labels
01 - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multinomial casts input to np.float64
3 participants
@bashtage @charris @eric-wieser
0