8000 TST: Add cygwin build to CI by DWesl · Pull Request #18330 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

TST: Add cygwin build to CI #18330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 21, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Wrap long line and change condition order.
I want the `sys.platform == "cygwin"` check before I try to access
`np.clongdouble`, so the check doesn't crash the test on platforms
where np.clongdouble doesn't exist.
  • Loading branch information
DWesl committed Jul 20, 2021
commit 52fa14eeebc6ad917eaf87e4e5185ed7a29bcfc1
12 changes: 8 additions & 4 deletions numpy/core/tests/test_scalarmath.py
Original file line number Diff line number Diff line change
Expand Up @@ -680,14 +680,18 @@ def _test_abs_func(self, absfunc, test_dtype):

@pytest.mark.parametrize("dtype", floating_types + complex_floating_types)
def test_builtin_abs(self, dtype):
if dtype == np.clongdouble and sys.platform == "cygwin":
pytest.xfail(reason="npy_cabsl calls npy_hypotl, which is npy_hypot")
if sys.platform == "cygwin" and dtype == np.clongdouble:
pytest.xfail(
reason="absl is computed in double precision on cygwin"
)
self._test_abs_func(abs, dtype)

@pytest.mark.parametrize("dtype", floating_types + complex_floating_types)
def test_numpy_abs(self, dtype):
if dtype == np.clongdouble and sys.platform == "cygwin":
pytest.xfail(reason="npy_cabsl calls npy_hypotl, which is npy_hypot")
if sys.platform == "cygwin" and dtype == np.clongdouble:
pytest.xfail(
reason="absl is computed in double precision on cygwin"
)
self._test_abs_func(np.abs, dtype)

class TestBitShifts:
Expand Down
0