8000 ENH, DOC: Build notes and fixes for Cygwin. by DWesl · Pull Request #18308 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH, DOC: Build notes and fixes for Cygwin. #18308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

ENH, DOC: Build notes and fixes for Cygwin. #18308

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e61028b
TST: Add Cygwin to the x86 feature tests.
DWesl Feb 1, 2021
2f20c93
BLD: Tell fortran compiler Cygwin doesn't support rpath.
DWesl Feb 1, 2021
e30548d
BLD: Change `cyg2win32` to use the `cygpath` utility.
DWesl Feb 1, 2021
a254171
TST: Parametrize a few more tests.
DWesl Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
TST: Add Cygwin to the x86 feature tests. 
This was suggested by @seiko2plus for debugging a segfault in the
tests on Cygwin:
#18102 (comment)

This test passes on Cygwin, and the whole testsuite has only the
failures I expect from running on Cygwin (see #18102 and #16246).
  • Loading branch information
@DWesl
DWesl committed Jul 21, 2021
commit e61028b7aa33872b9aa2259961eca2f888b301ce
5 changes: 4 additions & 1 deletion numpy/core/tests/test_cpu_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,12 @@ def load_flags_auxv(self):
)

is_linux = sys.platform.startswith('linux')
is_cygwin = sys.platform.startswith('cygwin')
machine = platform.machine()
is_x86 = re.match("^(amd64|x86|i386|i686)", machine, re.IGNORECASE)
@pytest.mark.skipif(not is_linux or not is_x86, reason="Only for Linux and x86")
@pytest.mark.skipif(
not (is_linux or is_cygwin) or not is_x86, reason="Only for Linux and x86"
)
class Test_X86_Features(AbstractTest):
features = [
"MMX", "SSE", "SSE2", "SSE3", "SSSE3", "SSE41", "POPCNT", "SSE42",
Expand Down
0