8000 ENH: Make `np.number` generic with respect to its precision by BvB93 · Pull Request #17540 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: Make np.number generic with respect to its precision #17540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 21, 2020
Merged

ENH: Make np.number generic with respect to its precision #17540

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c53797e
ENH: Added support for `number` precision
Oct 2, 2020
1816e44
ENH: Make `complexfloating` generic w.r.t 2 typevars
Oct 12, 2020
9e732c8
MAINT: Removed a now redundant `TODO` comment
Oct 12, 2020
fdf30fb
DOC: Fixed some docstring formatting
Oct 13, 2020
3ebabec
MAINT: Added a missing `__init__` method
Oct 16, 2020
a5f1757
MAINT: Fixed a few issues with the `__call__`-based protocols
Oct 16, 2020
b84946d
TST: Ignore all `*` characters in the reveal tests
Oct 16, 2020
27d5864
TST: Update the pre-existing tests
Oct 16, 2020
95a391c
TST: Add support for precision to the arithmetic and bitwise ops tests
Oct 16, 2020
3082bd7
TST: Added a test for the example in the `NBitBase` docstring
Oct 16, 2020
226b46b
MAINT: Removed an unused import
Oct 17, 2020
cd15084
TST: Update the tests introduced in the latest rebase
Oct 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TST: Ignore all * characters in the reveal tests 
Mypy uses a `*` whenever an annotation or one of its parameters is based on a TypeVar.

Its added value is neglible and it unnecessarily complicates the `reveal` tests so lets just ignore them.

Note that this is done after running mypy, so it won't affect cases where `*` is used as multiplication operator.
  • Loading branch information
Bas van Beek committed Oct 17, 2020
commit b84946d15e5b63f44cd4bbbc04e5230a18720afc
5 changes: 3 additions & 2 deletions numpy/typing/tests/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,10 @@ def test_reveal(path):
])

with open(path) as fin:
lines = fin.readlines()
lines = fin.read().replace('*', '').split("\n")

for error_line in stdout.split("\n"):
stdout_list = stdout.replace('*', '').split("\n")
for error_line in stdout_list:
error_line = error_line.strip()
if not error_line:
continue
Expand Down
0