10000 ENH: Add new ``numpy.ma.*`` aliases by takanori-pskq · Pull Request #17480 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add new numpy.ma.* aliases #17480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ENH: Add new numpy.ma.* aliases #17480

wants to merge 5 commits into from

Conversation

takanori-pskq
Copy link

Related to #13114, separated from #16300. Now parameter name fill_value collides in np.ma.full (see #16300 ).

@BvB93
Copy link
Member
BvB93 commented Oct 7, 2020

Can you also add the new aliases to numpy/ma/__init__.pyi?
Annotating them as Any (just like the rest) should be fine.

@takanori-pskq
Copy link
Author

Added type annotations.

@takanori-pskq takanori-pskq force-pushed the i13114-add-ma-aliases branch from 8d1837f to 57d33cf Compare October 7, 2020 14:36
@BvB93 BvB93 mentioned this pull request Oct 7, 2020
Merged
rossbar
rossbar reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor
@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full and full_like were the only problematic ones that jumped out to me from my previous review of #16300 (see this comment specifically). ones_like, zeros_like, and the *split functions avoid this problem and have nice tests.

I know you just split this one off from another PR, but I think everything aside from the full* functions is mergeable. If you were willing, the changes related to full* could be reverted/split off elsewhere to prevent that from blocking the rest.

@takanori-pskq takanori-pskq mentioned this pull request Oct 8, 2020
Closed
@rossbar rossbar self-requested a review October 8, 2020 02:55
@charris charris added 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes component: numpy.ma masked arrays labels Oct 11, 2020
@takanori-pskq takanori-pskq force-pushed the i13114-add-ma-aliases branch 2 times, most recently from 31ba45d to feeb1f7 Compare October 12, 2020 06:24
@takanori-pskq
Copy link
Author

Added release note.

Base automatically changed from master to main March 4, 2021 02:05
@bsipocz bsipocz mentioned this pull request Jul 16, 2022
Closed
@bsipocz
Copy link
Member
bsipocz commented Jul 16, 2022

Closing this PR now as its content is conflicting with main here. The rebased version can be found in #21998.

@bsipocz bsipocz closed this Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar Awaiting requested review from rossbar

Assignees
No one assigned
Labels
01 - Enhancement 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes component: numpy.ma masked arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@takanori-pskq @BvB93 @bsipocz @rossbar @charris
0