8000 ENH: add dtype option to numpy.lib.function_base.cov and corrcoef by lschwetlick · Pull Request #17456 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: add dtype option to numpy.lib.function_base.cov and corrcoef #17456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 9, 2020
Merged

ENH: add dtype option to numpy.lib.function_base.cov and corrcoef #17456

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
68639df
add dtype keyword to cov function. And add tests.
lschwetlick Oct 5, 2020
5d37cd7
add dtype keyword to corrcoef function. And add tests.
lschwetlick Oct 5, 2020
430efb6
add pass dtype argument to von inside corrcoef
lschwetlick Oct 5, 2020
1d8df25
move value error outside the dtype if
lschwetlick Oct 5, 2020
a804e47
use universal data type in test
lschwetlick Oct 5, 2020
65aeeaa
make dtype a keyword only argument
lschwetlick Oct 5, 2020
6c00943
fix Typo
lschwetlick Oct 5, 2020
199bf5d
use universal datatypes in cov test as well
lschwetlick Oct 5, 2020
5eaebff
make dtype a keyword only arg in corrcoef too
lschwetlick Oct 5, 2020
6f02d6d
fix function dispatcher signatures
lschwetlick Oct 5, 2020
4c8f86b
documentation
lschwetlick Oct 5, 2020
8e8af60
documentation edit
lschwetlick Oct 5, 2020
48adb31
DOC: release note touch-ups
rossbar Oct 5, 2020
f14a188
DOC: minor docstring touchups.
rossbar Oct 5, 2020
3738fae
DOC: reword dtype param description.
rossbar Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use universal datatypes in cov test as well
  • Loading branch information
@lschwetlick
lschwetlick committed Oct 5, 2020
commit 199bf5da2aa193be5b53c11a5556e1c20b5b0038
5 changes: 1 addition & 4 deletions numpy/lib/tests/test_function_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2129,11 +2129,8 @@ def test_unit_fweights_and_aweights(self):
aweights=self.unit_weights),
self.res1)

@pytest.mark.parametrize("test_type", [getattr(np, dtype, None) for dtype \
in ['float32', 'float64', 'float96', 'float128']])
@pytest.mark.parametrize("test_type", [np.half, np.single, np.double, np.longdouble])
def test_cov_dtype(self, test_type):
if test_type is None:
pytest.skip("Data type not available")
cast_x1 = self.x1.astype(test_type)
res = cov(cast_x1, dtype=test_type)
assert test_type == res.dtype
Expand Down
0