ENH, BLD: Support for the NVIDIA HPC SDK nvfortran compiler #17344
Conversation
numpy/distutils/fcompiler/pg.py
Outdated
| @@ -12,7 +12,7 @@ class PGroupFCompiler(FCompiler): | |||
|
|
|||
| compiler_type = 'pg' | |||
| description = 'Portland Group Fortran Compiler' | |||
There was a problem hiding this comment.
Should we update this description too?
There was a problem hiding this comment.
compiler_type might be also changed to "nv", but it will break compatibility for build script that uses --fcompiler=pg.
Should we create a all new compiler type nv.py and leave pg.py as is for older versions ?
There was a problem hiding this comment.
I think that's reasonable - but I think you need to also check distutils/fcompiler/__init__.py and add an entry to tests/test_public_api.py for the new compiler. There may be other places worth checking.
There was a problem hiding this comment.
Thanks for the hints.
I removed the modifications on the pg.py files and created the nv.py one instead.
|
I guess the flags would be the same as those for pgfortran on other platforms. |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Thanks @danbeibei . |
Add support for the nvfortran compiler, a version of pgfortran.
Closes #17341.