8000 ENH: Add annotations for five array construction functions by BvB93 · Pull Request #17326 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add annotations for five array construction functions #17326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 1, 2020
Merged

ENH: Add annotations for five array construction functions #17326

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d03a906
ENH,WIP: Added type hints to `np.core._asarray`
Aug 29, 2020
abe1429
ENH: Use literals where possible
Aug 29, 2020
37acf5f
TST: Added tests for `np.core._asarray`
Sep 16, 2020
e142934
TST: Consolidate all array construction tests
Sep 16, 2020
da2a854
ENH: Update the `np.__all__`
Sep 16, 2020
97c2216
MAINT: Minor fixes; removed unused imports
Sep 16, 2020
7794d05
ENH: Add an alias for `Union[_Requirements, _E]`
Sep 16, 2020
2af5962
MAINT: Replaced `__all__` with `import x as x`
Sep 23, 2020
be77442
MAINT: Removed placeholder annotations
Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TST: Added tests for np.core._asarray
  • Loading branch information
Bas van Beek committed Oct 1, 2020
commit 37acf5f73c05bfbd115eeefc6201c2212b240933
7 changes: 7 additions & 0 deletions numpy/typing/tests/data/fail/array_constructors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import numpy as np

a: np.ndarray

np.require(a, requirements=1) # E: No overload variant
np.require(a, requirements="TEST") # E: incompatible type

38 changes: 38 additions & 0 deletions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
from typing import List
import numpy as np

class SubClass(np.ndarray): ...

A = np.array([1])
B = A.view(SubClass).copy()
C = [1]

np.asarray(A)
np.asarray(B)
np.asarray(C)

np.asanyarray(A)
np.asanyarray(B)
np.asanyarray(B, dtype=int)
np.asanyarray(C)

np.ascontiguousarray(A)
np.ascontiguousarray(B)
np.ascontiguousarray(C)

np.asfortranarray(A)
np.asfortranarray(B)
np.asfortranarray(C)

np.require(A)
np.require(B)
np.require(B, dtype=int)
np.require(B, requirements=None)
np.require(B, requirements="E")
np.require(B, requirements=["ENSUREARRAY"])
np.require(B, requirements={"F", "E"})
np.require(B, requirements=["C", "OWNDATA"])
np.require(B, requirements="W")
np.require(B, requirements="A")
np.require(C)

38 changes: 38 additions & 0 deletions numpy/typing/tests/data/reveal/array_constructors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
from typing import List
import numpy as np

class SubClass(np.ndarray): ...

A: np.ndarray
B: SubClass
C: List[int]

reveal_type(np.asarray(A)) # E: ndarray
reveal_type(np.asarray(B)) # E: ndarray
reveal_type(np.asarray(C)) # E: ndarray

reveal_type(np.asanyarray(A)) # E: ndarray
reveal_type(np.asanyarray(B)) # E: SubClass
reveal_type(np.asanyarray(B, dtype=int)) # E: ndarray
reveal_type(np.asanyarray(C)) # E: ndarray

reveal_type(np.ascontiguousarray(A)) # E: ndarray
reveal_type(np.ascontiguousarray(B)) # E: ndarray
reveal_type(np.ascontiguousarray(C)) # E: ndarray

reveal_type(np.asfortranarray(A)) # E: ndarray
reveal_type(np.asfortranarray(B)) # E: ndarray
reveal_type(np.asfortranarray(C)) # E: ndarray

reveal_type(np.require(A)) # E: ndarray
reveal_type(np.require(B)) # E: SubClass
reveal_type(np.require(B, requirements=None)) # E: SubClass
reveal_type(np.require(B, dtype=int)) # E: ndarray
reveal_type(np.require(B, requirements="E")) # E: ndarray
reveal_type(np.require(B, requirements=["ENSUREARRAY"])) # E: ndarray
reveal_type(np.require(B, requirements={"F", "E"})) # E: ndarray
reveal_type(np.require(B, requirements=["C", "OWNDATA"])) # E: SubClass
reveal_type(np.require(B, requirements="W")) # E: SubClass
reveal_type(np.require(B, requirements="A")) # E: SubClass
reveal_type(np.require(C)) # E: ndarray

0