BUG: sysconfig attributes/distutils issue #17268
Conversation
* numpygh-17223 started the `distutils` modernization process because of the various upstream stuff going on (thanks) * that set of changes caused build issues with NumPy pre-release wheels + SciPy `master`: https://travis-ci.org/github/scipy/scipy/builds/725002838 * I was able to patch two separate issues and confirm that this feature branch restores the SciPy build locally: 1) in one case, `distutils.sysconfig.get_python_inc` was replaced with `distutils.get_python_inc`, which does not exist (probably a typo) 2) a bit more serious; even `sysconfig.get_python_inc` does not appear to exist; the closest match I could find (and that worked) was `sysconfig.get_path()` with options for general and platform-specific header paths as needed * I'm not claiming that these stdlib replacements are perfect either (the prefix case may still be slightly different?), but it does prevent the SciPy build break originally introduced as a start
|
Thanks @tylerjereddy, sorry for the breakage. As this is confirmed to work with SciPy, and our CI apparently does not cover these (otherwise there would have been failing tests), there is no need to wait for CI to merge. Hopefully it will not break other downstream packages. |
|
I guess we could try to write a test for this |
|
I've triggered new wheel builds that should have this fix. |
I suspect we'll be much better off in keeping our pins to setuptools <50.0, waiting till things have stabilized with the distutils inclusion in setuptools, then doing the whole migration in one go with SciPy and other builds as the integration test suite of that change.
|
MAINT: use sysconfig not distutils.sysconfig where possible #17223 started the
distutilsmodernizationprocess because of the various upstream stuff
going on (thanks)
that set of changes caused build issues with NumPy
pre-release wheels + SciPy
master:https://travis-ci.org/github/scipy/scipy/builds/725002838
I was able to patch two separate issues and confirm
that this feature branch restores the SciPy build locally:
distutils.sysconfig.get_python_incwasreplaced with
distutils.get_python_inc, which does notexist (probably a typo)
sysconfig.get_python_incdoesnot appear to exist; the closest match I could find (and
that worked) was
sysconfig.get_path()with options forgeneral and platform-specific header paths as needed
either (the prefix case may still be slightly different?), but
it does prevent the SciPy build break originally introduced
as a start