-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
DOC: Use official MATLAB spelling in numpy-for-matlab-users.rst #17215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update the MATLAB case L53 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…nto matlabcopyright
|
@melissawm and @eric-wieser that was a good idea to catch the case as well as the (R) symbols. Current commit 233d281 updates all Matlab and matlab to MATLAB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cooperrc ! I'm just not sure what's going on with the CI...
replace (R) in reference to Mathworks reference Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
I'm not sure either. Its odd that the checks were having trouble. |
|
8000
Thanks Ryan, circleci is happy, so all good! |
|
Will there now be merge conflicts with #17159, where many changed lines include the 'matlab' string in its various forms? |
|
Oh, yeah :(, that is probably an annoying merge conflict there |
|
|
@eric-wieser, should I run this, then push the changes? |
|
Yes, I think so.You'll I'd recommend running git pull origin # get any changes from the other PR made in the web version
git fetch upstream # or whatever you called this repo
git tag just-in-case-i-break-it
git rebase -Xtheirs upstream/master
git push origin -f |
|
OK, its been done. First glance looks ok. I was nervous with the Thanks @eric-wieser! |
There is a current PR #17159, where we (@eric-wieser @melissawm @bjnath @seberg) are updating the numpy-for-matlab-users.rst guide.
Comment suggested updating the copytright (R) symbols as per MATLAB's suggested use:
@bjnath: