8000 DOC: Add correctness vs strictness consideration for np.dtype by anirudh2290 · Pull Request #16917 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

DOC: Add correctness vs strictness consideration for np.dtype #16917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2020
Merged

DOC: Add correctness vs strictness consideration for np.dtype #16917

merged 5 commits into from
Aug 3, 2020

Conversation

anirudh2290
Copy link
Member

Document _DTypeLike decision for correctness vs strictness. Please see : #16891

Depends on #16622

@anirudh2290 anirudh2290 mentioned this pull request Jul 20, 2020
Closed
rossbar
rossbar reviewed Jul 21, 2020
View reviewed changes
@anirudh2290 @rossbar
MAINT: Update numpy/typing/__init__.py
19ce11b 
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
BvB93
BvB93 reviewed Jul 21, 2020
View reviewed changes
BvB93
BvB93 reviewed Jul 21, 2020
View reviewed changes
@BvB93 BvB93 linked an issue Jul 21, 2020 that may be closed by this pull request
Should we error on "not-recommended" behavior in static typing tests ? #16891
Closed
anirudh2290 and others added 2 commits July 21, 2020 13:54
person142
person142 reviewed Jul 23, 2020
View reviewed changes
@BvB93 BvB93 mentioned this pull request Jul 30, 2020
Merged
BvB93
BvB93 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member
@BvB93 BvB93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and #16622 has now been merged.

@BvB93 BvB93 merged commit 5b5a740 into numpy:master Aug 3, 2020
@BvB93
Copy link
Member
BvB93 commented Aug 3, 2020

Thanks @anirudh2290.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar left review comments

@person142 person142 person142 left review comments

@BvB93 BvB93 BvB93 approved these changes

Assignees
No one assigned
Labels
04 - Documentation 41 - Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we error on "not-recommended" behavior in static typing tests ?
4 participants
@anirudh2290 @BvB93 @rossbar @person142
0