ENH, BLD: Add RPATH support for AIX #16710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Jun 30, 2020
anirudh2290
approved these changes
Jul 7, 2020
|
Given that this section is rewritten, might as well use f-strings for readability. I'll make the change if you want. NVM, I made the change. |
|
Thanks @EGuesnet . |
charris
added a commit
to charris/numpy
that referenced
this pull request
Jul 8, 2020
* ENH: Add RPATH support for AIX * ENH: Rewrite function returning RPATH * MAINT: Use f-strings for clarity. Co-authored-by: Charles Harris <charlesr.harris@gmail.com>
20 tasks
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The
runtime_library_dir_option()function does not implement the RPATH equivalent on AIX. This PR adds this support, using LIBPATH (= AIX RPATH).Scipy needs this function to be implemented to be built. With this PR, Scipy can be built.