8000 ENH: Add ``__f2py_numpy_version__`` attribute to Fortran modules. by sturlamolden · Pull Request #16594 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add __f2py_numpy_version__ attribute to Fortran modules. #16594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

ENH: Add __f2py_numpy_version__ attribute to Fortran modules. #16594

merged 1 commit into from
Jun 18, 2020

Conversation

sturlamolden
Copy link
Contributor

The Fortran module now reports the version of NumPy associated with the f2py used for compilation. Closes gh-16525.

@sturlamolden sturlamolden changed the title add __f2py_numpy_version__ attribute ENH: Add __f2py_numpy_version__ attribute to Fortran modules. Jun 13, 2020
@sturlamolden
Copy link
Contributor Author
sturlamolden commented Jun 13, 2020 •
edited
Loading

The purpose of this PR is to gracefully handle situations like this:

scipy/scipy#9658
#16513
scipy/scipy#12319

If we know the version of NumPy used for compilation (not the imported one) users of f2py (e.g. SciPy) can gracefully turn off workarounds for known f2py bugs, if we know the workaround to otherwise be detrimental. Not having the attribute __f2py_numpy_version__ is also informative because we then know the f2py version to be one that came prior to inclusion of this PR.

@sturlamolden
Copy link
Contributor Author

Ping @pv

pv
pv reviewed Jun 13, 2020
View reviewed changes
Copy link
Member
@pv pv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can add a test, maybe here: https://github.com/numpy/numpy/blob/master/numpy/f2py/tests/test_regression.py

mattip
mattip reviewed Jun 15, 2020
View reviewed changes
Copy link
Member
@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @pv any last comments?

eric-wieser
eric-wieser reviewed Jun 15, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed Jun 15, 2020
View reviewed changes
@sturlamolden sturlamolden force-pushed the f2py-version-fix2 branch 2 times, most recently from c7a2cf9 to e574f1e Compare June 17, 2020 04:41
@sturlamolden
Copy link
Contributor Author

Finally it is green again 😅

@seberg
Copy link
Member
seberg commented Jun 18, 2020

Seems like everyone was happy with this decision, and the code looks good to me as well. Thanks @sturlamolden.

@seberg seberg merged commit a69ce06 into numpy:master Jun 18, 2020
@sturlamolden sturlamolden mentioned this pull request Aug 5, 2020
Open
@charris charris mentioned this pull request Oct 10, 2020
Closed
20 tasks
@charris charris changed the title ENH: Add __f2py_numpy_version__ attribute to Fortran modules. ENH: Add __f2py_numpy_version__ attribute to Fortran modules. Oct 20, 2020
charris added a commit to charris/numpy that referenced this pull request Nov 22, 2020
@charris
DOC: Add numpygh-16594 to NumPy 1.20.0 release notes.
8448143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pv pv pv left review comments

@eric-wieser eric-wieser eric-wieser left review comments

@mattip mattip mattip left review comments

Assignees
No one assigned
Labels
component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: f2py does not correctly report the f2py version in the docstrings of compiled extension modules
5 participants
@sturlamolden @seberg @pv @eric-wieser @mattip
0