BLD: Avoid "visibility attribute not supported" warning. #16343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that when building the latest master branch on Cygwin, while testing numpy#16246, that thousands of warnings were generated at build time like: numpy/core/src/npysort/binsearch.c.src: In function ‘binsearch_left_bool’: numpy/core/src/npysort/binsearch.c.src:82:1: warning: visibility attribute not supported in this configuration; ignored [-Wattributes] Granted this is just a warning, so I don't think it's a serious issue. It seems the test that was supposed to check for __attribute__ support was not working as expected. The #pragmas only take effect if I provide a function body--they are ignored for bare declarations. I don't know if that's by intent, or if it's a GCC issue. For reference: $ gcc --version gcc (GCC) 7.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16288.
I found that when building the latest master branch on Cygwin, while
testing #16246, that thousands of warnings were generated at build time
like:
numpy/core/src/npysort/binsearch.c.src: In function
‘binsearch_left_bool’: numpy/core/src/npysort/binsearch.c.src:82:1:
warning: visibility attribute not supported in this configuration;
ignored [-Wattributes] Granted this is just a warning, so I don't think
it's a serious issue.
It seems the test that was supposed to check for attribute support
was not working as expected. The #pragmas only take effect if I provide
a function body--they are ignored for bare declarations. I don't know if
that's by intent, or if it's a GCC issue. For reference:
$ gcc --version
gcc (GCC) 7.4.0