8000 ENH: Allow pickle with protocol 5 when higher is requested by jakirkham · Pull Request #16185 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

ENH: Allow pickle with protocol 5 when higher is requested #16185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2020

Conversation

jakirkham
Copy link
Contributor

Previously we were checking that protocol 5 was matched exactly. However it should be fine if a newer protocol was used as well. So check that at least protocol 5 was used (though newer is fine too).

jakirkham added 2 commits May 7, 2020 15:54
Previously we were checking that protocol 5 was matched exactly. However
it should be fine if a newer protocol was used as well. So check that at
least protocol 5 was used (though newer is fine too).
@eric-wieser
Copy link
Member

xref gh-12748, cc @pitrou

@charris
Copy link
Member
charris commented May 12, 2020

@pitrou Ping.

Copy link
Member
@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seberg seberg changed the title Handle out-of-band buffers with protocol 5+ ENH: Allow pickle with protocol 5 when larger was requested May 12, 2020
@seberg seberg changed the title ENH: Allow pickle with protocol 5 when larger was requested ENH: Allow pickle with protocol 5 when higher is requested May 12, 2020
@seberg
Copy link
Member
seberg commented May 12, 2020

Thanks @jakirkham and @pitrou for clarifying! Putting it in.

@seberg seberg merged commit beb031d into numpy:master May 12, 2020
@jakirkham jakirkham deleted the check_protocol_5_or_newer branch May 12, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0