8000 ENH: better handle dtype creation with metadata by dmbelov · Pull Request #15962 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: better handle dtype creation with metadata #15962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

ENH: better handle dtype creation with metadata #15962

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0be11e
Fixed code that creats dtype with metadata, see issue #15488.
dmbelov Apr 13, 2020
0f9a4d7
Fixed test_fromat.py: non of the tests in test_metadata_dtype fails i…
dmbelov Apr 13, 2020
85274d7
fix
dmbelov Apr 13, 2020
d032cf6
Replaced function _check_if_size_1_and_contains_name_and_tuple by _is…
dmbelov Apr 13, 2020
9d0ee49
Improved clarity of the code. Added more tests.
dmbelov Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@dmbelov
dmbelov committed Apr 25, 2020
commit 85274d744c64971b3d0737d006fcafeede83c9ee
2 changes: 1 addition & 1 deletion numpy/lib/tests/test_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,5 +978,5 @@ def test_metadata_dtype(dt, fail, has_metadata):
from numpy.lib.format import _has_metadata
assert_array_equal(arr, arr2)
assert _has_metadata(arr.dtype)
assert _has_metadata(arr2.dtype) or not has_metadata
assert _has_metadata(arr2.dtype) == has_metadata

0