8000 MAINT: Remove duplicated code in iotools.py by eric-wieser · Pull Request #15883 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

MAINT: Remove duplicated code in iotools.py #15883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

eric-wieser
Copy link
Member
@eric-wieser eric-wieser commented Mar 31, 2020

This will conflict with #15731, in that it merges together lines that are changed twice.

Copy link
Member
@anirudh2290 anirudh2290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor! LGTM.

@@ -711,6 +711,26 @@ def __call__(self, value):
return self._callingfunction(value)
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this PR, but looks like these "#" should be removed.

@mattip mattip merged commit 8c2112d into numpy:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0