MAINT, DOC: Remove use of old Python __builtin__, now known as builtins #15418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Jan 24, 2020
| else: | ||
| from __builtin__ import bool, int, float, complex, object, unicode, str | ||
| from builtins import bool, int, float, complex, object, str | ||
| unicode = str |
There was a problem hiding this comment.
unicode is also defined in np.compat. We may want to deal with that at some point. It is unfortunate that it is part of the default numpy api.
|
Thanks @mwtoews . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2's
__builtin__module is replaced with thebuiltinsmodule.A few notes:
numpy/__init__.py, which are not touched here, just re-arranged to remove Python 2 logicnumpy/core/defchararray.pywill work in Sphinx outputs (the current__builtin__.lendoes not link)numpy/distutils/misc_util.py.