10000 BUG: do not emit warnings for np.sign, np.equal when using nan by WarrenWeckesser · Pull Request #15230 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: do not emit warnings for np.sign, np.equal when using nan #15230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2020
Merged

BUG: do not emit warnings for np.sign, np.equal when using nan #15230

merged 2 commits into from
Jan 6, 2020

Conversation

WarrenWeckesser
Copy link
Member

This is a continuation of #15209.

@WarrenWeckesser WarrenWeckesser changed the title BUG: do not emit warnings for np.sign, np.equal when using nan WIP/BUG: do not emit warnings for np.sign, np.equal when using nan Jan 3, 2020
@WarrenWeckesser
Copy link
Member Author

The last update handles the endianess in a nicer way. Thanks, @seberg!

@WarrenWeckesser WarrenWeckesser changed the title WIP/BUG: do not emit warnings for np.sign, np.equal when using nan BUG: do not emit warnings for np.sign, np.equal when using nan Jan 3, 2020
eric-wieser
eric-wieser reviewed Jan 3, 2020
View reviewed changes
@mattip mattip mentioned this pull request Jan 4, 2020
Closed
@mattip
Copy link
Member
mattip commented Jan 4, 2020

Fixes gh-15127

@mattip mattip requested a review from eric-wieser January 4, 2020 15:49
@seberg
Copy link
Member
seberg commented Jan 6, 2020

Lets put this in, thanks all!

@seberg seberg merged commit b66864c into numpy:master Jan 6, 2020
@seberg seberg mentioned this pull request Jan 6, 2020
Closed
@mhvk mhvk mentioned this pull request Jan 8, 2020
Merged
@Zac-HD Zac-HD mentioned this pull request Jan 9, 2020
Merged
5 tasks
@dstansby
Copy link
Contributor

👋 thanks for this change! I was just wondering which version of numpy it will first appear in?

@greglucas greglucas mentioned this pull request Apr 14, 2020
Open
@WarrenWeckesser WarrenWeckesser deleted the mattip-isssue-15127 branch October 15, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattip mattip mattip approved these changes

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees
No one assigned
Labels
00 - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WarrenWeckesser @mattip @seberg @dstansby @eric-wieser
0