MAINT: Cleaned up mintypecode for Py3 #14967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
385c852 to
a5cd4a1
Compare
|
Thanks, looks good at first sight. Could you remove the release note again? I think it is unnecessary here. |
a5cd4a1 to
0b83bf9
Compare
|
@seberg Done |
Using generators instead of full-blown lists Using set for search instead of list Using min to get single element insteaf of sorting full list
eric-wieser
reviewed
Nov 24, 2019
| l = [(_typecodes_by_elsize.index(t), t) for t in intersection] | ||
| l.sort() | ||
| return l[0][1] | ||
| return min((_typecodes_by_elsize.index(t), t) for t in intersection)[1] |
There was a problem hiding this comment.
Better as:
return min(intersection, key=_typecodes_by_elsize.index)
|
@eric-wieser well seen. I've updated the branch. @seberg I don't know how it works when I change the branch after a merge. |
madphysicist
added a commit
to madphysicist/numpy
that referenced
this pull request
Nov 24, 2019
This reverts commit 2fb8540.
|
You would have to create a new PR for followups. |
|
You can create a new PR from the same branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small cleanup PR for
mintypecode.All changes are internal, and should be relatively uncontroversial. As such no tests were modified in this PR.