BUG: fix fromfile behavior when reading sub-array dtypes #14657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore previous behavior of fromfile, by ensuring the original dtype is used for reading, instead of the type of the created array which may have sub-arrays collapsed. Reverts parts of 454c5b5
|
Thanks, the second part of the test causes a use after free/decref, another old bug that was simply not covered. I will have a look at it probably later today. |
|
I pushed a followup, we can squash. |
|
LGTM, and does not regress #14586 to print the refcount errors. |
|
Thanks! (Eventually green scipy CI :) |
|
@pv I'll generate another set of testing wheels, I was waiting for this PR to go in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied
2BB5
from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore previous behavior of fromfile, by ensuring the original dtype is
used for reading, instead of the type of the created array which may
have sub-arrays collapsed.
Reverts parts of 454c5b5
Closes: gh-14646