BUG: Fix randint when range is 2**32 #14501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d1248a to
7d43968
Compare
|
This only affects 1.17.x, correct? |
|
Yes. The only discussion point is that this affects both RandomState, which
must be fixed, and Generator, which could be left as is (with a negligible
perf penalty). The downside of splitting is extra code complexity. This PR
has changed both.
…On Sat, Sep 14, 2019, 00:08 Charles Harris ***@***.***> wrote:
This only affects 1.17.x, correct?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14501?email_source=notifications&email_token=ABKTSRJ5YNPKUUIQFYDWGGTQJQMP7A5CNFSM4IWUXHMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WMTVI#issuecomment-531417557>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKTSRNBOYSS5VF3CO5Y2LTQJQMP7ANCNFSM4IWUXHMA>
.
|
mattip
reviewed
Sep 14, 2019
mattip
reviewed
Sep 14, 2019
|
minor nit in formatting, otherwise LTGM. Will merge soon even without the formatting fix, it seems we will have to carefully check the release note rendering anyway. |
Fix randint to use 32-bit path when range is exactly 2**32 closes numpy#14189
7d43968 to
5e148ad
Compare
|
Thanks @bashtage |
This was referenced Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix randint to use 32-bit path when range is exactly 2**32
closes #14189