BLD: Only allow using Cython module when cythonizing.#14410
BLD: Only allow using Cython module when cythonizing.#14410rgommers merged 1 commit intonumpy:masterfrom
Conversation
The command line version of `cython` may point to a different installation of Cython than that installed in the Python running the cythonize script. Because the Cython version can be critical, requiring that the cython used comes from a known place makes it less likely that the wrong version will be used. This treats Cython as a build dependency rather than a free standing compiler.
There was a problem hiding this comment.
LGTM, not sure if there was discussion elsewhere, but I think this can just go in. Sounds a bit like hitting the PATH version almost certainly gives a wrong one (although I suppose it might be convenient when working with virtual envs).
|
So SciPy needs this tools change as well? I usually do |
In my case, |
|
Note that NumPy cythonize has the required version hard wired in. We should look to getting that from the |
We now have a |
There was a problem hiding this comment.
adding the build dependency is needed for this PR, otherwise we're just breaking some use cases that are perfectly fine.
Yes, along with the EDIT: Check... Looks like |
|
I'm adding the build dependency in gh-14453, so let's leave this as is. |
|
Okay, let's give this a try. Thanks Chuck! |
The command line version of
cythonmay point to a differentinstallation of Cython than that installed in the Python running the
cythonize script. Because the Cython version can be critical, requiring
that the cython used comes from a known place makes it less likely that
the wrong version will be used. This treats Cython as a build dependency
rather than a free standing compiler.