8000 BUG: view with fieldless dtype should raise if itemsize != 0 by ahaldane · Pull Request #14393 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: view with fieldless dtype should raise if itemsize != 0 #14393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2019
Merged

BUG: view with fieldless dtype should raise if itemsize != 0 #14393

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
847aefc
BUG: view with fieldless dtype should raise if itemsize != 0
ahaldane Aug 28, 2019
9b740ef
BUG: PyDataType_ISUNSIZED should be False for structured types
ahaldane Aug 31, 2019
7c3adfb
BUG: Fix comparison of fieldless structured arrays
ahaldane Aug 31, 2019
d6f7524
BUG: Fix fieldless comparison broadcasting
ahaldane Sep 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
BUG: view with fieldless dtype should raise if itemsize != 0 
Fixes #14344
  • Loading branch information
@ahaldane
ahaldane committed Aug 28, 2019
commit 847aefc8a5dc239f2937cf369de0895e94e78533
3 changes: 2 additions & 1 deletion numpy/core/include/numpy/ndarraytypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,7 +1695,8 @@ PyArray_CLEARFLAGS(PyArrayObject *arr, int flags)
#define PyDataType_ISOBJECT(obj) PyTypeNum_ISOBJECT(((PyArray_Descr*)(obj))->type_num)
#define PyDataType_HASFIELDS(obj) (((PyArray_Descr *)(obj))->names != NULL)
#define PyDataType_HASSUBARRAY(dtype) ((dtype)->subarray != NULL)
#define PyDataType_ISUNSIZED(dtype) ((dtype)->elsize == 0)
#define PyDataType_ISUNSIZED(dtype) ((dtype)->elsize == 0 && \
!PyDataType_HASFIELDS(dtype))
#define PyDataType_MAKEUNSIZED(dtype) ((dtype)->elsize = 0)

#define PyArray_ISBOOL(obj) PyTypeNum_ISBOOL(PyArray_TYPE(obj))
Expand Down
5 changes: 5 additions & 0 deletions numpy/core/tests/test_dtype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,11 @@ def test_partial_dict(self):
assert_raises(ValueError, np.dtype,
{'formats': ['i4', 'i4'], 'f0': ('i4', 0), 'f1':('i4', 4)})

def test_fieldless_views(self):
a = np.zeros(2, dtype={'names':[], 'formats':[], 'offsets':[],
'itemsize':8})
assert_raises(ValueError, a.view, np.dtype([]))


class TestSubarray(object):
def test_single_subarray(self):
Expand Down
0