BUG: Make advanced indexing result on read-only subclass writeable #14171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
approved these changes
Aug 1, 2019
Co-Authored-By: Eric Wieser <wieser.eric@gmail.com>
Co-Authored-By: Eric Wieser <wieser.eric@gmail.com>
|
Thanks @jeremiedbb and Eric. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Aug 5, 2019
…umpy#14171) Fancy indexing on read-only subclass makes a read-only copy. This PR avoids using the flags of the original array. Fixes numpy#14132 * do not use original array flags in fancy indexing * Update numpy/core/tests/test_indexing.py Co-Authored-By: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14132
Fancy indexing on read-only subclass makes a read-only copy. This PR avoids using the flags of the original array.