MAINT: Change the type of error raised in set_printoptions #13899
Conversation
|
I don't think this is an improvement - passing If you want to go down this path, then you should split the condition in two, and raise |
c2c5f66 to
cdffafd
Compare
|
@eric-wieser You are right. I have split it into two conditions. |
There was a problem hiding this comment.
@mattip, think the message is still clear enough for clueless stackoverflow users using threshold='nan'?
|
Needs a release note because of changed behavior. |
cdffafd to
8564444
Compare
|
Hi @charris , I added a release note. |
|
@charris @eric-wieser @mattip Anything else need to be changed? |
|
I think it would be best to wait for the #13908 stuff to go in first - your release note is in the wrong place, but the right place is about to change. |
|
@kianasun can you move your release note into the file EDIT: Sorry, you have to rebase on master first, or the changelog folder will not exist. |
|
@seberg Sure! will do this soon. |
8564444 to
55a8193
Compare
Co-Authored-By: Sebastian Berg <sebastian@sipsolutions.net>
|
Thanks @kianasun! |
No description provided.