MAINT: Remove Python <= 3.4 logic and imports #13852
Conversation
|
We probably won't merge this right away in order to keep code differences with 1.17 to a minimum until it settles down. |
|
Ah, I suspected this could have been the case. I can revise and merge this PR with HEAD when the time comes. |
|
The test failures are legitimate. |
|
All tests now pass (except for Shippable -- no idea why). A few too many |
|
I restarted the Shippable job for you |
|
All tests now pass. While I'm holding back putting too many changes in one PR, other related modifications include:
|
|
@mwtoews Time to get started. I would recommend breaking this up into smaller chunks for easier review. That could either be by task -- remove |
|
@charris agree with the strategy to break this into a few commits (based on type of modification), and to try to avoid removing module functions potentially imported downstream. |
|
@mwtoews folks have been going wild on the cleanup, so this PR is probably out of date. |
|
There are likely still a few very good things in here, unfortunately big chunks of this are already done or being finished e.g. in gh-15335. May be interesting to get some of the cleanups out of here, but if not, this is probably soon simply outdated. (ping @sethtroisi, just in case) |
|
I'll take a look and pick-up remaining edits. I might just |
|
This PR is now mostly superseded by various other PRs. |
|
I'm pulling all the remaining parts out of this into a new PR |
This PR aims to remove and simplify Python code that was intended for Python 2 and Python <= 3.4, which are no longer supported.
The focus here is primarily around
if sys.version_info[0] >= 3blocks, but also removes unnecessary ImportErrors for modules that are part of the Python >=3.5 standard library. Some comments regarding compatibility are retained, but not all.Careful reviews and comments are most appreciated!