ENH: SFC64 BitGenerator #13838
Merged
ENH: SFC64 BitGenerator #13838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
reviewed
Jun 26, 2019
|
|
||
| cdef _reset_state_variables(self): | ||
| self.rng_state.has_uint32 = 0 | ||
| self.rng_state.uinteger = 0 |
There was a problem hiding this comment.
The two lines from this function can be inlined into __init__
|
Thanks Robert. |
Sign up for free
to join this conversation on GitHub.
Already ha
6333
ve an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces mattip#41
Adds just the
SFC64BitGenerator, as discussed. There's still a little bit of documentation to spruce up, but other PRs currently in flight would conflict, so I'll do a documentation pass later.