MAINT: Correct masked aliases #13688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f352dc4 to
d8d9fac
Compare
mattip
reviewed
Jun 1, 2019
numpy/random/__init__.py
Outdated
| @@ -177,7 +177,6 @@ | |||
| 'ThreeFry', 'Xoshiro256', 'Xoshiro512', 'RandomState'] | |||
|
|
|||
| # Some aliases: | |||
| ranf = random = sample = random_sample | |||
| __all__.extend(['ranf', 'random', 'sample']) | |||
There was a problem hiding this comment.
Nit: this could get a cleanup and be moved to the huge __all__ list above, which should get a comment that these are all imported with from mtrand import *
Expose alias that have correct docstrings closes numpy#10587
d8d9fac to
68c81c1
Compare
eric-wieser
approved these changes
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose alias that have correct docstrings
closes #10587
closes #7512