8000 MAINT: Collect together the special-casing of 0d nonzero into one place by eric-wieser · Pull Request #13632 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Collect together the special-casing of 0d nonzero into one place #13632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2019
Merged

MAINT: Collect together the special-casing of 0d nonzero into one place #13632

merged 2 commits into from
Jun 3, 2019

Conversation

eric-wieser
Copy link
Member
@eric-wieser eric-wieser commented May 26, 2019 •
edited
Loading

Brought on by #13522, in an attempt to make it clear why this happens.

Will follow up with a PR suggesting a deprecation (edit: #13708)

@mattip
Copy link
Member
mattip commented May 31, 2019

Fails to compile cleanly:

 numpy/core/src/multiarray/item_selection.c:2220:16: warning: passing argument 4 of ‘PyArray_NewFromDescrAndBase’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  numpy/core/src/multiarray/item_selection.c:2220:32: warning: passing argument 5 of ‘PyArray_NewFromDescrAndBase’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  numpy/core/src/multiarray/item_selection.c:2210:9: warning: unused variable ‘is_empty’ [-Wunused-variable]

@eric-wieser eric-wieser force-pushed the tidy-nonzero branch 3 times, most recently from a93fdb4 to a178733 Compare June 1, 2019 08:51
@eric-wieser
Copy link
Member Author
eric-wieser commented Jun 1, 2019 •
edited
Loading

Unfortunately my windows builds don't emit any warnings about incorrect usage of const, so this is requiring a lot of CI hits.

Will probably split out the const-ness into a separate PR once this passes (edit: #13693)

@eric-wieser eric-wieser mentioned this pull request Jun 1, 2019
Merged
@mattip mattip merged commit 40ada70 into numpy:master Jun 3, 2019
@mattip
Copy link
Member
mattip commented Jun 3, 2019

Nice cleanup, thanks Eric

@eric-wieser eric-wieser mentioned this pull request Jun 4, 2019
Merged
@eric-wieser eric-wieser changed the title MAINT: Collect together the special-casing of 0d non-zero into one place MAINT: Collect together the special-casing of 0d nonzero into one place Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
< 4EE8 input type="hidden" data-csrf="true" name="authenticity_token" value="PIj9iOK8li4G8msyDRzjKRiJlGXd/a7KEldx1APzbnDef18g+ncDqKN4CO6zi1dqbnBwTRWfKM/ZeeNJC+80pQ==" />
Assignees
No one assigned
Labels
03 - Maintenance component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-wieser @mattip
0