BLD: Make CI pass again with pytest 4.5 #13534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicoddemus Is this an expected change requirement for pytest 4.5, which just showed up in our CI? |
|
@charris Notes that this change doesn't get propagated to wheels though. |
|
@charris suggests maybe handling in |
|
@tylerjereddy: Seems like a good idea, but agreed with people in person that it makes sense as a follow up. Merging this to unblock other CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to register
valgrind_errorandslowas pytest markers to avoid warnings from pytest >= 4.5.0 that are turned into errors.