BUG: distutils/system_info.py fix missing subprocess import #13523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy/distutils/system_info.py
Outdated
| @@ -2409,6 +2409,7 @@ def get_config_exe(self): | |||
| return self.default_config_exe | |||
|
|
|||
| def get_config_output(self, config_exe, option): | |||
| import subprocess | |||
There was a problem hiding this comment.
There's an import subprocess as sp above in this module, conditional on platform. Maybe there's some historical stuff I don't know about subprocess availability but I suppose we could just import at top level these days?
There was a problem hiding this comment.
We import subprocess all over distutils, lets move this import to the top.
|
Thanks @denniszollo . |
charris
added a commit
that referenced
this pull request
May 20, 2019
BUG: distutils/system_info.py fix missing subprocess import (#13523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue installing numpy from an enthought package called enable on MacOS high sierra and python 3.5 and python 3.6. It seems that subprocess is not imported where needed in the system_info.py file.