8000 BUG: Fix incorrect/missing reference cleanups found using valgrind by seberg · Pull Request #12624 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Fix incorrect/missing reference cleanups found using valgrind #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 2, 2019
Merged

BUG: Fix incorrect/missing reference cleanups found using valgrind #12624

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3b69c78
BUG: Fix incorrect/missing reference cleanups found using valgrind
seberg Dec 27, 2018
defdc74
BUG: Add missing DECREF to datetime metadata fetcher
seberg Dec 28, 2018
71803e6
BUG: Fix some smaller memory leaks in various places
seberg Dec 28, 2018
040c5e3
BUG: Add missing free to ufunc axis remapping auxiliar data
seberg Dec 28, 2018
67e89c6
BUG: Add missing decrefs for the vectorized string functions
seberg Dec 28, 2018
a12e392
BUG: Remove unnecessary dtype incref in FromArray view path
seberg Dec 28, 2018
aae353a
TST: decref temporary in getset_numericops test
seberg Dec 28, 2018
d37b17b
BUG: Remove spurious incref in ufunc reductions with memory overlap
seberg Dec 28, 2018
8a68950
TST: Resolve circular/recursive references in test_arrayprint
seberg Dec 28, 2018
f152795
BUG: Fix incorrect cleanup iterators in nditer_constr.c
seberg Dec 28, 2018
340ebea
TST: Missing dtype decref in _struct_ufunc_tests
seberg Dec 28, 2018
3c6cb19
BUG: Fix two descriptor related leaks
seberg Dec 29, 2018
2e51fdd
BUG: Missing decref of new descr in `_use_inherit` error paths
seberg Dec 29, 2018
8000
13868b1
BUG: Fix leaks timedelta from object array dtype construction
seberg Dec 29, 2018
0f1500a
BUG: Add missing names decref to argsort/argpartition (sort is good)
seberg Dec 29, 2018
4732c1b
Fixup for commit 67e89c68876a37109b1288932976df1ef2225b59
seberg Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixup for commit 67e89c6 
The XDECREF is not required, the type cannot be NULL.
  • Loading branch information
@seberg
seberg committed Jan 2, 2019
commit 4732c1be2da093711ab544f6e0a302b9d7ee4bcb
12 changes: 6 additions & 6 deletions numpy/core/src/multiarray/multiarraymodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3620,15 +3620,15 @@ _vec_string_with_args(PyArrayObject* char_array, PyArray_Descr* type,
if (nargs == -1 || nargs > NPY_MAXARGS) {
PyErr_Format(PyExc_ValueError,
"len(args) must be < %d", NPY_MAXARGS - 1);
Py_XDECREF(type);
Py_DECREF(type);
goto err;
}

broadcast_args[0] = (PyObject*)char_array;
for (i = 1; i < nargs; i++) {
PyObject* item = PySequence_GetItem(args, i-1);
if (item == NULL) {
Py_XDECREF(type);
Py_DECREF(type);
goto err;
}
broadcast_args[i] = item;
Expand All @@ -3637,7 +3637,7 @@ _vec_string_with_args(PyArrayObject* char_array, PyArray_Descr* type,
in_iter = (PyArrayMultiIterObject*)PyArray_MultiIterFromObjects
(broadcast_args, nargs, 0);
if (in_iter == NULL) {
Py_XDECREF(type);
Py_DECREF(type);
goto err;
}
n = in_iter->numiter;
Expand Down Expand Up @@ -3718,7 +3718,7 @@ _vec_string_no_args(PyArrayObject* char_array,

in_iter = (PyArrayIterObject*)PyArray_IterNew((PyObject*)char_array);
if (in_iter == NULL) {
Py_XDECREF(type);
Py_DECREF(type);
goto err;
}

Expand Down Expand Up @@ -3775,7 +3775,7 @@ static PyObject *
_vec_string(PyObject *NPY_UNUSED(dummy), PyObject *args, PyObject *kwds)
{
PyArrayObject* char_array = NULL;
PyArray_Descr *type = NULL;
PyArray_Descr *type;
PyObject* method_name;
PyObject* args_seq = NULL;

Expand Down Expand Up @@ -3812,7 +3812,7 @@ _vec_string(PyObject *NPY_UNUSED(dummy), PyObject *args, PyObject *kwds)
result = _vec_string_with_args(char_array, type, method, args_seq);
}
else {
Py_XDECREF(type);
Py_DECREF(type);
PyErr_SetString(PyExc_TypeError,
"'args' must be a sequence of arguments");
goto err;
Expand Down
0