8000 BUG: Add missing free in ufunc dealloc by seberg · Pull Request #12617 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Add missing free in ufunc dealloc #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Conversation

seberg
Copy link
Member
@seberg seberg commented Dec 26, 2018

Fixup cleanup of ufunc (definitely lost in valgrind). See also gh-12615, tested with valgrind and this seems all ufunc related lost memory right now.

@charris charris added this to the 1.16.0 release milestone Dec 26, 2018
@charris
Copy link
Member
charris commented Dec 26, 2018

Hmm, the azure error is odd, but it is in matmul, which is now a ufunc.

@charris
Copy link
Member
charris commented Dec 26, 2018

ISTR seeing that error before. I think the warning originates elsewhere and doesn't get cleaned up. There is no reason for it in that test AFAICT.

@charris charris merged commit d0aa124 into numpy:master Dec 26, 2018
@charris
Copy link
Member
charris commented Dec 26, 2018

Thanks Sebastian.

@seberg seberg deleted the ufunc-cleanup branch December 26, 2018 22:34
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Dec 27, 2018
@charris charris removed this from the 1.16.0 release milestone Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0