BUG: fix PyDataType_ISBOOL #12131
Merged
BUG: fix PyDataType_ISBOOL #12131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
approved these changes
Oct 10, 2018
|
Something is off with the codecov/project check. Is there a way to ignore some of the inconsistent files? |
|
Thanks Matti. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PyDataType_ISBOOLmacro still uses_PyADt, but that value was removed in commit db8442b04 from 2006. So the macro was broken for quite a while, and nobody complained. I propose fixing it, although deletingPyDataType_ISBOOLentirely is another alternative.