8000 MAINT Avoid some memory copies in numpy.polynomial.hermite by rth · Pull Request #12073 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT Avoid some memory copies in numpy.polynomial.hermite #12073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2018
Merged

MAINT Avoid some memory copies in numpy.polynomial.hermite #12073

merged 1 commit into from
Nov 1, 2018

Conversation

rth
Copy link
Contributor
@rth rth commented Oct 2, 2018

This avoids a few memory copies in numpypolynomial.hermite* by using np.full instead of cst*np.ones, with hopefully some marginal run time benefits.

@rth rth force-pushed the numpy-full-polynomial branch from ae51554 to fe76cc7 Compare October 2, 2018 22:41
@mattip
Copy link
Member
mattip commented Oct 16, 2018

The line changed is not tested. Could you add a test? Since this is a change to increase performance, a benchmark in benchmarks/benchmark would be even nicer, but I don't see any benchmarking at all for polynomial.

@eric-wieser
Copy link
Member

Not sure this is worth benchmarking, but a test of these paths would be good

@charris charris merged commit 9cc9f01 into numpy:master Nov 1, 2018
@charris
Copy link
Member
charris commented Nov 1, 2018

Thanks @rth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance 59 - Needs tests component: numpy.polynomial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rth @mattip @eric-wieser @charris @tylerjereddy
0