8000 ENH: initial implementation of core `__array_function__` machinery by shoyer · Pull Request #12005 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: initial implementation of core __array_function__ machinery #12005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 24, 2018
Merged

ENH: initial implementation of core __array_function__ machinery #12005

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
781d855
ENH: initial implementation of core __array_function__ machinery
shoyer Sep 21, 2018
4ece3b1
Add test for ndarray.__array_function__
shoyer Sep 21, 2018
a05d1c2
Add an interface test
shoyer Sep 21, 2018
ea13501
Fix test failures checking __doc__ attribute
shoyer Sep 21, 2018
415f327
Add initial benchmarks for __array_function__
shoyer Sep 22, 2018
234ca89
Add another test for unimplemented __array_function__
shoyer Sep 22, 2018
ac2e2f3
Add comment on subclasses ordering
shoyer Sep 24, 2018
0da1b95
Fix precedence of ndarray subclasses and misc cleanup
shoyer Sep 24, 2018
1846ac3
CLN: remove the internal Benchmark class
shoyer Sep 24, 2018
ceba9b3
Merge branch 'master' into nep-18-initial
shoyer Sep 24, 2018
692d2b4
CLN: optimize ndarray.__array_function__
shoyer Sep 24, 2018
c0cf617
Revert removal of Benchmark class
shoyer Sep 24, 2018
fbc6ad4
Revert goal_time -> sample_time
shoyer Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment on subclasses ordering
  • Loading branch information
@shoyer
shoyer committed Sep 24, 2018
commit ac2e2f3cb3c2f6fb8424abc48a9509d32011360d
3 changes: 3 additions & 0 deletions numpy/core/overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ def get_overloaded_types_and_args(relevant_args):
overloaded_types.append(arg_type)

if array_function is not ndarray.__array_function__:
# By default, insert this argument at the end, but if it is
# subclass of another argument, insert it before that argument.
# This ensures "subclasses before superclasses".
index = len(overloaded_args)
for i, old_arg in enumerate(overloaded_args):
if issubclass(arg_type, type(old_arg)):
Expand Down
0