8000 BUG: reference cycle in np.vectorize by mattip · Pull Request #11977 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: reference cycle in np.vectorize #11977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2019
Merged

BUG: reference cycle in np.vectorize #11977

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0267264
BUG: use cyclic garbage collection semantics in np.frompyfunc
mattip Sep 18, 2018
f73d96d
MAINT: cleanup comments and harmless reference assignment
mattip Dec 4, 2018
a3b9f75
MAINT: fixes from review
mattip Dec 18, 2018
7474a71
MAINT: fix from review
mattip Jan 9, 2019
82419c0
MAINT: simplify test (seberg)
mattip Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MAINT: simplify test (seberg)
  • Loading branch information
@mattip
mattip committed Jan 9, 2019
commit 82419c00ed41899990d8a0d332535d246edc4147
33 changes: 13 additions & 20 deletions numpy/lib/tests/test_function_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,42 +1511,35 @@ def bound(self, *args):
def unbound(*args):
return 0

def npy_bound(self, a):
return types.MethodType(np.frompyfunc(self.bound, 1, 1), a)

def npy_unbound(self, a):
return np.frompyfunc(self.unbound, 1, 1)

@pytest.mark.skipif(not HAS_REFCOUNT, reason="Python lacks refcounts")
@pytest.mark.parametrize('func, npy_func, incr', [
# Test with both an unbound method and a bound one
(A.bound, A.npy_bound, A.iters),
(A.unbound, A.npy_unbound, 0),
@pytest.mark.parametrize('name, incr', [
('bound', A.iters),
('unbound', 0),
])
def test_frompyfunc_leaks(self, func, npy_func, incr):
def test_frompyfunc_leaks(self, name, incr):
# exposed in gh-11867 as np.vectorized, but the problem stems from
# frompyfunc.
# class.attribute = np.frompyfunc(<method>) creates a
# reference cycle if <method> is a bound class method that requires a
# gc collection cycle to break (on CPython 3)
# reference cycle if <method> is a bound class method. It requires a
# gc collection cycle to break the cycle (on CPython 3)
import gc

A_func = getattr(self.A, name)
gc.disable()
try:
refcount = sys.getrefcount(func)
refcount = sys.getrefcount(A_func)
for i in range(self.A.iters):
a = self.A()
a.f = npy_func(a, a)
a.f = np.frompyfunc(getattr(a, name), 1, 1)
out = a.f(np.arange(10))
a = None
if PY2:
assert_equal(sys.getrefcount(func), refcount)
assert_equal(sys.getrefcount(A_func), refcount)
else:
# func is part of a reference cycle
assert_equal(sys.getrefcount(func), refcount + incr)
# A.func is part of a reference cycle if incr is non-zero
assert_equal(sys.getrefcount(A_func), refcount + incr)
for i in range(5):
gc.collect()
assert_equal(sys.getrefcount(func), refcount)
assert_equal(sys.getrefcount(A_func), refcount)
finally:
gc.enable()

Expand Down
0