WIP, TST: include missing source files in gcov report #11791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* gcov requires *.gcda files to have newer timestamps than *.c and *.gcno files; this causes some C source files to be ignored in coverage report, so we now explicitly touch all *.gcda files before running gcov in CI
|
The CI will pass here, but the issue is not fixed as the problematic statements are still visible in the output for |
|
One possible complication for me to check -- we use
|
|
Closing in favor of my proposal to adjust Matti's PR slightly as that seems to work locally to avoid the C cov issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11790
See the linked issue for details -- this initial attempt is probably a bit optimistic, but I'm having a hard time reproducing the problem locally on my mac.