8000 BUG: Ensure singleton dimensions are not dropped when converting ctype arrays to dtypes by eric-wieser · Pull Request #11652 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Ensure singleton dimensions are not dropped when converting ctype arrays to dtypes #11652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2018
Merged

BUG: Ensure singleton dimensions are not dropped when converting ctype arrays to dtypes #11652

merged 1 commit into from
Aug 1, 2018

Conversation

eric-wieser
Copy link
Member
@eric-wieser eric-wieser commented Aug 1, 2018 •
edited
Loading

This fixes #11636

Also adds xfailing tests for related issues (#10533, #11651)

This bug has been around forever, but it surfaced in new places due to some of my cleanup elsewhere, so I think is worth of a backport.

As usual, trivially backportable using the web ui

@eric-wieser
BUG: Ensure singleton dimensions are not dropped when converting ctyp…
78b85e0 
…e arrays to dtypes

This fixes numpy#11636

Also adds xfailing tests for related issues
@codecov-io
Copy link
codecov-io commented Aug 1, 2018 •
edited
Loading

Codecov Report

Merging #11652 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11652      +/-   ##
==========================================
+ Coverage    85.7%   85.71%   +<.01%     
==========================================
  Files         327      327              
  Lines       82016    82050      +34     
==========================================
+ Hits        70295    70329      +34     
  Misses      11721    11721
Impacted Files Coverage Δ
numpy/core/tests/test_dtype.py 97.23% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0a136...78b85e0. Read the comment docs.

@eric-wieser eric-wieser mentioned this pull request Aug 1, 2018
Closed
@charris charris merged commit 066298b into numpy:master Aug 1, 2018
@charris
Copy link
Member
charris commented Aug 1, 2018

Thanks Eric.

@charris
Copy link
Member
charris commented Aug 1, 2018

Will you do the backport or should I?

@eric-wieser eric-wieser mentioned this pull request Aug 1, 2018
Merged
@eric-wieser
Copy link
Member Author

I've gone ahead and done it

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug 06 - Regression component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array shape is lost during as_ctypes/as_array round trip in 1.15
3 participants
@eric-wieser @codecov-io @charris
0