MAINT: Improve memory usage in PEP3118 format parsing #11535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the test needs for filter out a warning. |
Previously a local `Stream` class would be defined every time a format needed parsing. Classes in cpython create reference cycles, which create load on the GC. This may or may not resolve numpygh-6511
Codecov Report
@@ Coverage Diff @@
## master #11535 +/- ##
==========================================
+ Coverage 85.7% 85.71% +0.01%
==========================================
Files 327 327
Lines 81985 81994 +9
==========================================
+ Hits 70264 70282 +18
+ Misses 11721 11712 -9
Continue to review full report at Codecov.
|
|
I'm pretty certain the codecov message spam is because the PR feature branch hasn't been rebased on the latest master branch, which contains the config settings to disable these comments. So, the codecov service is enabled but doesn't see those settings in this PR yet. |
|
@charris: Good to go? |
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a local
Streamclass would be defined every time a format needed parsing.Classes in cpython create reference cycles, which create load on the GC.
This may or may not resolve gh-6511