8000 ENH: Improve support for pathlib.Path objects in load functions by paulmueller · Pull Request #11348 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: Improve support for pathlib.Path objects in load functions #11348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 1, 2018
Merged

ENH: Improve support for pathlib.Path objects in load functions #11348

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bd3309d
ENH: Improve support for pathlib.Path objects in load functions
paulmueller Jun 15, 2018
c4e5aa1
tests: fix permission error on windows (memmap file not closed)
paulmueller Jun 16, 2018
2e1bc67
Merge branch 'master' into path-updates
paulmueller Oct 13, 2018
07cc4b6
ENH: Improve support for pathlib.Path objects in load functions
paulmueller Jun 15, 2018
d2d1571
tests: fix permission error on windows (memmap file not closed)
paulmueller Jun 16, 2018
6e2db10
Merge branch 'path-updates' of github.com:paulmueller/numpy into path…
paulmueller Oct 31, 2018
84a0b77
tests: add comment
paulmueller Nov 1, 2018
271f3e3
use new os_fspath
paulmueller Nov 1, 2018
5ce8d95
docs: update path-like references
paulmueller Nov 1, 2018
05ddb68
update release notes
paulmueller Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: fix permission error on windows (memmap file not closed)
  • Loading branch information
@paulmueller
paulmueller committed Oct 31, 2018
commit d2d15719973315c8271b47935a2a2e1c29bed465
1 change: 1 addition & 0 deletions numpy/lib/tests/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2311,6 +2311,7 @@ def test_save_load_memmap(self):
np.save(path, a)
data = np.load(path, mmap_mode='r')
assert_array_equal(data, a)
del data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for this line? A comment might be nice

Copy link
Contributor Author
@paulmueller paulmueller Oct 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required such that numpy closes the mem-mapped file. Otherwise you will get weird errors on Windows.


def test_save_load_memmap_readwrite(self):
# Test that pathlib.Path instances can be written mem-mapped.
Expand Down
0