8000 TST: Test dimensions/indices found from parsed gufunc signatures. by mhvk · Pull Request #11178 · numpy/numpy · GitHub < 8000 meta name="analytics-location" content="/<user-name>/<repo-name>/voltron/pull_requests_fragments/pull_request_layout" data-turbo-transient="true" />
[go: up one dir, main page]
Skip to content

TST: Test dimensions/indices found from parsed gufunc signatures.#11178

Merged
eric-wieser merged 1 commit intonumpy:masterfrom
mhvk:gufunc-signature-testing-improvement
May 29, 2018
Merged

TST: Test dimensions/indices found from parsed gufunc signatures.#11178
eric-wieser merged 1 commit intonumpy:masterfrom
mhvk:gufunc-signature-testing-improvement

Conversation

@mhvk
Copy link
Copy Markdown
Contributor
@mhvk mhvk commented May 28, 2018

Another split-off from #11132 - expanded signature testing.

@mhvk mhvk requested a review from mattip May 28, 2018 14:21
@mhvk mhvk mentioned this pull request May 28, 2018
Closed
eric-wieser
eric-wieser reviewed May 28, 2018
View reviewed changes
numpy/core/tests/test_ufunc.py 8000 Outdated
Copy link
Copy Markdown
Member
@eric-wieser eric-wieser May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nicer to build a nested tuple here, and I don't envisage it being any harder

eric-wieser
eric-wieser approved these changes May 28, 2018
View reviewed changes
Copy link
Copy Markdown
Member
@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but fine to merge as is

@mhvk
Copy link
Copy Markdown
Contributor Author
mhvk commented May 28, 2018

I think for the testing purposes here it is perhaps better to just give back what the ufunc contains. I have been wondering more generally, though, about some way to expose this information -- maybe as simple as a nicer __repr__ -- and then I think it would be good to distinguish more clearly.

@mhvk mhvk force-pushed the gufunc-signature-testing-improvement branch from c1233ed to d0e5e39 Compare May 28, 2018 17:41
@mhvk
Copy link
Copy Markdown
Contributor Author
mhvk commented May 28, 2018

@mattip - are you happy with this going in separately? (I do apologize for hijacking your PR...)

@eric-wieser
Copy link
Copy Markdown
Member
eric-wieser commented May 28, 2018

for the testing purposes here it is perhaps better to just give back what the ufunc contains

Arguably the ufunc just contains a representation of nested tuple, split between num_dims and idx. So I'd maybe just return (core_enabled, tuple_of_idx).

I don't feel strongly about this - looks like a good thing to test however you spell it

@mattip
Copy link
Copy Markdown
Member
mattip commented May 29, 2018

LGTM, breaking the larger work into a number of smaller PRs is the way to go

@eric-wieser eric-wieser merged commit b1cb954 into numpy:master May 29, 2018
@mhvk mhvk deleted the gufunc-signature-testing-improvement branch May 29, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@mattip mattip Awaiting requested review from mattip

Assignees

No one assigned

Labels

05 - Testing component: numpy._core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhvk @eric-wieser @mattip
0