TST: windows builds now properly support floating error states #11160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we fix this at our end? If so, can you reference where in the commit message? |
|
I don't really know the history. I tried it now on windows python2.7 with the appropriate old MSVC compiler, and the test passed locally, and I see all the CI bots are green. |
|
@eric-wieser The history would be nice to have, but it doesn't seem worth the effort to chase it down at this point. |
|
Yep, I was just checking if any of us knew the history - it's not worth digging for. |
|
Thanks @mattip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows now properly supports floating point error states. Fixes #2350