8000 TST: Skip ctypes dependent test that fails on Python < 2.7.7. by mattip · Pull Request #11159 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

TST: Skip ctypes dependent test that fails on Python < 2.7.7. #11159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2018
Merged

TST: Skip ctypes dependent test that fails on Python < 2.7.7. #11159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
10000
Diff view
1 change: 1 addition & 0 deletions numpy/core/tests/test_multiarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6517,6 +6517,7 @@ def test_max_dims(self):
a = np.empty((1,) * 32)
self._check_roundtrip(a)

@pytest.mark.skipif(sys.version_info < (2, 7, 7), reason="See gh-11115")
Copy link
Member
@eric-wieser eric-wieser May 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer either:

  • relies on bpo-10744 being fixed
  • relies on https://bugs.python.org/issue10744 being fixed

At any rate, we can just refer to the python issue here - the github one is not interesting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eric-wieser The Python issue seems a bit less discoverable and the numpy reference has a fair amount of useful discussion. Given that we will drop 2.7 support at the end of the year, probably not worth spending much time on this. If nothing else, git blame will lead back here.

def test_error_too_many_dims(self):
def make_ctype(shape, scalar_type):
t = scalar_type
Expand Down
0