[WIP] ENH: Improve mixed edge type handling by histogramdd #11067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think #11023 will need to go in before trying to implement this |
|
#11023 has been merged |
|
I think I'll close this one for now -- it is not in a state where it is anywhere near ready & not something I / others seemed hugely passionate about pushing forward. We can always resurrect the effort if priorities shift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11024
Before I start mucking around in the source code, I thought I'd try to draft a few unit tests for the behavior we'd expect for a "simple" mixture of datetime and float input to
histogramdd.Naturally, datetime work can be a bit tricky; perhaps the most obvious issue that came up as I was drafting the unit test -- for datetime bin edges, is there an unambiguously clear "winner" in terms of a robust way to take i.e., "days" (or whatever datetime object the user provides) and "cast" it to a unit (like microseconds since the epoch) that can easily be subdivided for the various bin edge division scenarios?