8000 DOC: Make doc examples using StringIO python2-3 compatible by adeak · Pull Request #10996 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@adeak
Copy link
Contributor
@adeak adeak commented Apr 27, 2018

On python 3 StringIO can only be imported from io, but then io.StringIO needs unicode input on python 2. The python 2-3 polyglot solution is to import from io and use u-strings in the examples, see also #10991.

I was also going to update the outputs in the docstrings, but then I ran into #10990.

Fixes #10511.

@juliantaylor
Copy link
Contributor

thanks

@juliantaylor juliantaylor merged commit db552b5 into numpy:master Apr 27, 2018
@adeak adeak deleted the docfix-stringio-unicode branch April 28, 2018 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0