DOC: link to governance, convert external link to internal #10980
Conversation
| @@ -1,7 +1,7 @@ | |||
| About NumPy | |||
| =========== | |||
|
|
|||
| `NumPy <http://www.scipy.org/NumpPy/>`__ is the fundamental package | |||
There was a problem hiding this comment.
This link had a typo in it anyway!
doc/source/about.rst
Outdated
| @@ -42,6 +42,8 @@ Our main means of communication are: | |||
|
|
|||
| More information about the development of NumPy can be found at our `Developer Zone <https://scipy.scipy.org/scipylib/dev-zone.html>`__. | |||
|
|
|||
| The project management structure can be found at our `governance page <dev/governance/index.html>`__ | |||
There was a problem hiding this comment.
Does this really need the .html? Won't that make it fail if rendered using a different sphinx renderer?
| @@ -18,7 +18,7 @@ Before reading this, it may help to familiarize yourself with the basics | |||
| of C extensions for Python by reading/skimming the tutorials in Section 1 | |||
| of `Extending and Embedding the Python Interpreter | |||
| <http://docs.python.org/extending/index.html>`_ and in `How to extend | |||
| NumPy <http://docs.scipy.org/doc/numpy/user/c-info.how-to-extend.html>`_ | |||
| NumPy <c-info.how-to-extend.html>`_ | |||
There was a problem hiding this comment.
Guessing this .html can be stripped too?
Is there any easy way to check the rendered docs for PRs like this?
There was a problem hiding this comment.
Fixed and squashed, good catch. The html generates a valid http link in the document, so I don't know how we could catch it other than a grep,
grep "html>" -r . --include='*.rst' --include=*.py | grep -v http
now catches only the internal links to NEP docs, which are correct since they point to documents not rendered via the numpy repe
|
Thanks Matti. |
one more doc cleanup pull request. This: